moomindani commented on a change in pull request #28953:
URL: https://github.com/apache/spark/pull/28953#discussion_r451388011
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -122,6 +122,37 @@ object JdbcUtils extends Logging {
}
}
+ /**
+ * Runs a custom query against a table from the JDBC database.
+ */
+ def runQuery(conn: Connection, actions: String, options: JDBCOptions): Unit
= {
+ val autoCommit = conn.getAutoCommit
+ conn.setAutoCommit(false)
+ val queries = actions.split(";")
+ try {
+ queries.foreach { query =>
+ val queryString = query.trim()
+ val statement = conn.prepareStatement(queryString)
+ try {
+ statement.setQueryTimeout(options.queryTimeout)
+ val hasResultSet = statement.execute()
Review comment:
I added some tests for DDLs. As far as I tested,
`addBatch()`/`executeBatch()` worked also for DDLs.
It seems it also works for MySQL Connector/J since `executeBatch` just calls
`executeUpdate` internally.
https://github.com/mysql/mysql-connector-j/blob/dbd865c9fc68701efc70197ea1e65002520bed91/src/main/user-impl/java/com/mysql/cj/jdbc/StatementImpl.java#L859
I found a blog post which used `addBatch()`/`executeBatch()` with MySQL.
https://www.roseindia.net/tutorial/java/jdbc/jdbcbatch/jdbcbatchdatabasetablecreation.html
However, I could not find any clear documentation which says DDLs are
supported in `executeBatch()`. What I could find is that DDLs are supported in
`executeUpdate()` and `executeLargeUpdate()`.
https://docs.oracle.com/en/java/javase/11/docs/api/java.sql/java/sql/Statement.html
Should we move from (a) to (b) as safer approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
