frankyin-factual commented on a change in pull request #28898:
URL: https://github.com/apache/spark/pull/28898#discussion_r451393487
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasingSuite.scala
##########
@@ -493,6 +491,156 @@ class NestedColumnAliasingSuite extends SchemaPruningTest
{
comparePlans(optimized3, expected3)
}
+ test("Nested field pruning for Window") {
+ val spec = windowSpec($"address" :: Nil, $"id".asc :: Nil,
UnspecifiedFrame)
+ val winExpr = windowExpr(RowNumber(), spec)
+
+ val query1 = contact
+ .select($"name.first", winExpr.as('window))
+ .analyze
+ val optimized1 = Optimize.execute(query1)
+ val expected1 = contact
+ .select($"name.first", $"address", $"id")
+ .window(Seq(winExpr.as("window")), Seq($"address"), Seq($"id".asc))
+ .select($"first", $"window")
+ .analyze
+ comparePlans(optimized1, expected1)
Review comment:
Exactly, this isn’t improved in this pr as it always works. Not sure
whether we want to remove this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
