HeartSaVioR edited a comment on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655744956
Thanks for sharing the test failure, @dongjoon-hyun . I took a quick look, and realized 245aee9fc85c22352bb946a8987229270ba6069f was landed only on master branch (as it's an improvement) which got rid of size call in destination path, whereas branch-3.0 and branch-2.4 don't. Below is the commit I fixed the test in branch-3.0 (confirmed test passed): https://github.com/HeartSaVioR/spark/commit/6a36c9c072d0c7aeb29e12439d66d8205e2d5d7d and I also confirmed the test pass if we cherry pick 245aee9fc85c22352bb946a8987229270ba6069f to branch-3.0: https://github.com/HeartSaVioR/spark/commit/c8c9531858aa1d59fdb948d8840ea1f0ad2f1415 I'm now applying the fix to branch-2.4 - IDE requires rebuild on switching 3.x vs 2.x so it'd take time, but the mechanism of the fix should be applied to 2.4 as well. Would we like to go with hotfix, or cherry pick 245aee9fc85c22352bb946a8987229270ba6069f? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
