cloud-fan commented on a change in pull request #28983:
URL: https://github.com/apache/spark/pull/28983#discussion_r452060678
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/udaf.scala
##########
@@ -517,3 +519,18 @@ case class ScalaAggregator[IN, BUF, OUT](
override def nodeName: String = agg.getClass.getSimpleName
}
+
+/**
+ * An extension rule to resolve encoder expressions from a [[ScalaAggregator]]
+ */
+object ResolveEncodersInScalaAgg extends Rule[LogicalPlan] {
+ override def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperatorsUp
{
+ case p if !p.resolved => p
+ case p => p.transformExpressionsUp {
+ case agg: ScalaAggregator[_, _, _] =>
+ agg.copy(
+ inputEncoder = agg.inputEncoder.resolveAndBind(),
Review comment:
A followup we can do is to resolve and bind using the actual input data
types, so that we can do casting or reorder fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
