yaooqinn commented on a change in pull request #29052:
URL: https://github.com/apache/spark/pull/29052#discussion_r452072690
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -1159,7 +1159,7 @@ case class StringLocate(substr: Expression, str:
Expression, start: Expression)
override def children: Seq[Expression] = substr :: str :: start :: Nil
override def nullable: Boolean = substr.nullable || str.nullable
override def dataType: DataType = IntegerType
- override def inputTypes: Seq[DataType] = Seq(StringType, StringType,
IntegerType)
+ override def inputTypes: Seq[DataType] = Seq(StringType, IntegerType)
Review comment:
the expected input types here should match child expressions. The i-th
position in the returned seq indicates the type requirement for the i-th child.
So I guess this change is wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
