Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r27128892
--- Diff: pom.xml ---
@@ -1472,6 +1473,45 @@
<groupId>org.scalatest</groupId>
<artifactId>scalatest-maven-plugin</artifactId>
</plugin>
+ <!-- Build the JARs-->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <configuration>
+ <!-- Configuration of the archiver -->
+ <archive>
+ <manifestEntries>
+ <mode>development</mode>
+ <url>${project.url}</url>
+ </manifestEntries>
+ <manifest>
+
<addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
+
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
+ </manifest>
+ </archive>
+ </configuration>
+ <executions>
+ <execution>
--- End diff --
Yeah it can be mysterious; I feel reasonably sure about how the jar plugin
works. I'd rather remove the config if we don't know that it's needed, and I
have never need these. I also don't re-specify the default jar execution and
it's been fine. We'll know quickly of course whether it doesn't actually
produce JARs! but yeah I'd trim this down to what is necessary IMHO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
