HyukjinKwon commented on a change in pull request #29057:
URL: https://github.com/apache/spark/pull/29057#discussion_r452251691
##########
File path: python/pyspark/sql/tests/test_arrow.py
##########
@@ -435,12 +438,12 @@ def test_createDateFrame_with_category_type(self):
assert_frame_equal(result_spark, result_arrow)
# ensure original category elements are string
- self.assertIsInstance(category_first_element, str)
+ self.assertIsInstance(category_first_element, basestring)
# spark data frame and arrow execution mode enabled data frame type
must match pandas
self.assertEqual(spark_type, 'string')
self.assertEqual(arrow_type, 'string')
- self.assertIsInstance(arrow_first_category_element, str)
- self.assertIsInstance(spark_first_category_element, str)
+ self.assertIsInstance(arrow_first_category_element, basestring)
+ self.assertIsInstance(spark_first_category_element, basestring)
Review comment:
This is rather a followup of SPARK-25351. We didn't drop Python 2 yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
