nchammas commented on a change in pull request #27908:
URL: https://github.com/apache/spark/pull/27908#discussion_r449098102
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala
##########
@@ -338,7 +371,8 @@ class CatalogImpl(sparkSession: SparkSession) extends
Catalog {
tableType = tableType,
storage = storage,
schema = schema,
- provider = Some(source)
+ provider = Some(source),
+ comment = Some(description)
Review comment:
I chose `description` to match the existing `Table` class:
https://github.com/apache/spark/blob/86cc907448f0102ad0c185e87fcc897d0a32707f/sql/core/src/main/scala/org/apache/spark/sql/catalog/interface.scala#L68
Would you like me to change this PR to `comment`? I guess we will have an
inconsistency one way or the other.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala
##########
@@ -338,7 +371,8 @@ class CatalogImpl(sparkSession: SparkSession) extends
Catalog {
tableType = tableType,
storage = storage,
schema = schema,
- provider = Some(source)
+ provider = Some(source),
+ comment = Some(description)
Review comment:
Good point. Fixed. I made `description` an `Option[String]`. (I _think_
that's the right thing to do here...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
