AngersZhuuuu commented on a change in pull request #29035:
URL: https://github.com/apache/spark/pull/29035#discussion_r452587775
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateResolvedHint.scala
##########
@@ -43,6 +43,22 @@ object EliminateResolvedHint extends Rule[LogicalPlan] {
case h: ResolvedHint =>
hintErrorHandler.joinNotFoundForJoinHint(h.hints)
h.child
+ case join: Join if join.condition.isDefined =>
+ join.copy(
+ hint = join.hint.copy(
+ leftHint = removeCartesianProductJoinHint(join.hint.leftHint),
+ rightHint = removeCartesianProductJoinHint(join.hint.rightHint)))
+ }
+ }
+
+ def removeCartesianProductJoinHint(hint: Option[HintInfo]): Option[HintInfo]
= {
Review comment:
Since we don't know the join keys's condition is `EqualTo` or
`EaultNullSafe` so it's better just not remove it in `ExtractEqualJoinKeys`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
