Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5178#discussion_r27159189
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -81,7 +89,38 @@ private[spark] class DiskBlockManager(blockManager:
BlockManager, conf: SparkCon
new File(subDir, filename)
}
- def getFile(blockId: BlockId): File = getFile(blockId.name)
+ /** Looks up a file by blockManagerId */
+ // This method should be kept in sync with
+ //
org.apache.spark.network.shuffle.StandaloneShuffleBlockManager#getFile().
+ def getFile(filename: String, blockManagerId: BlockManagerId): File = {
--- End diff --
should this be called `getLocalFile`? Also the javadoc should explicitly
say that the given `blockManagerId` is expected to refer to an executor started
on this particular machine (i.e. it should be local).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
