dongjoon-hyun commented on a change in pull request #29061:
URL: https://github.com/apache/spark/pull/29061#discussion_r452599722
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
##########
@@ -116,6 +116,12 @@ object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
case CreateMap(children, useStringTypeWhenEmpty) =>
CreateMap(children.map(normalize), useStringTypeWhenEmpty)
+ case If(cond, trueValue, falseValue) =>
+ If(cond, normalize(trueValue), normalize(falseValue))
+
+ case CaseWhen(branches, elseVale) =>
Review comment:
Could you narrow-down the PR title? For example, instead of `certain
children expressions`, you can mention `IF` and `CaseWhen` specifically because
this PR only handles those two.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
