zhengruifeng commented on pull request #29018: URL: https://github.com/apache/spark/pull/29018#issuecomment-656487627
I had removed the specialization in those methods, expect in `TreePoint`, but there seems no significant improvement. I need more time to figure out while it is slower. > I honestly don't know how often the training is limited by memory vs CPU here? It is a trade-off between RAM vs CPU. I think CPU is a bit more important, since the training dataset tend to fit in memory. But if it can reduce 70% RAM usage at the cost of <5% slower, I think it worthwhile. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
