Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/5137#issuecomment-86203899
@yanboliang That's great to test on real datasets, but we should not
include them. It's better to generate data or use tiny datasets, as in
existing doc tests.
I've added my main comments above. My only other one is about adding doc
tests, but it sounds like you're working on that. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
