Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5144#discussion_r27163980
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -347,11 +349,13 @@ object SparkSubmit {
     
           // Standalone cluster only
           // Do not set CL arguments here because there are multiple 
possibilities for the main class
    -      OptionAssigner(args.jars, STANDALONE, CLUSTER, sysProp = 
"spark.jars"),
    +      OptionAssigner(args.jars, STANDALONE | MESOS, CLUSTER, sysProp = 
"spark.jars"),
           OptionAssigner(args.ivyRepoPath, STANDALONE, CLUSTER, sysProp = 
"spark.jars.ivy"),
    -      OptionAssigner(args.driverMemory, STANDALONE, CLUSTER, sysProp = 
"spark.driver.memory"),
    -      OptionAssigner(args.driverCores, STANDALONE, CLUSTER, sysProp = 
"spark.driver.cores"),
    -      OptionAssigner(args.supervise.toString, STANDALONE, CLUSTER,
    +      OptionAssigner(args.driverMemory, STANDALONE | MESOS, CLUSTER,
    +        sysProp = "spark.driver.memory"),
    +      OptionAssigner(args.driverCores, STANDALONE | MESOS, CLUSTER,
    +        sysProp = "spark.driver.cores"),
    +      OptionAssigner(args.supervise.toString, STANDALONE | MESOS, CLUSTER,
    --- End diff --
    
    maybe we need to reorganize this part a little. Currently it still says `// 
Standalone cluster only`. We should just move everything to under `// Other 
options`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to