gaborgsomogyi commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r452755289
########## File path: core/src/main/scala/org/apache/spark/security/SecurityConfigurationLock.scala ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.security + +import org.apache.spark.annotation.DeveloperApi + +/** + * ::DeveloperApi:: + * There are cases when global JVM security configuration must be modified. + * In order to avoid race the modification must be synchronized with this. + */ +@DeveloperApi +object SecurityConfigurationLock Review comment: I've had a deeper consideration and here are my findings. Adding global synchronization would give the impression that it's needed under any circumstances (which is not true). A good example is when one uses TGT ticket cache file, such case no need to modify global JVM configuration. From technical point of view this would not generate any issue for now. From logical point of view synchronizing something which may not required is bad message (+ such guarantee is hard to revoke if anything forces us to do so). Considering this I would not add synchronization into the framework. WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
