peter-toth commented on a change in pull request #29053:
URL: https://github.com/apache/spark/pull/29053#discussion_r452913572
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelationSuite.scala
##########
@@ -67,6 +68,28 @@ class PropagateEmptyRelationSuite extends PlanTest {
comparePlans(optimized, correctAnswer)
}
+ test("SPARK-32241: remove empty relation children from Union") {
Review comment:
A simple test case like here:
https://github.com/apache/spark/pull/29053/commits/b454cd71fbd69bb0edf5113dbc0e72d70db5a6fd
is ok? Or you want me to test that `UpdateAttributeNullability` kicks in and
fixes some nullability after `PropagateEmptyRelation`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
