warrenzhu25 commented on a change in pull request #29044:
URL: https://github.com/apache/spark/pull/29044#discussion_r452920847
##########
File path: bin/load-spark-env.cmd
##########
@@ -29,10 +29,7 @@ if [%SPARK_ENV_LOADED%] == [] (
set SPARK_CONF_DIR=%~dp0..\conf
)
- set SPARK_ENV_CMD=%SPARK_CONF_DIR%\%SPARK_ENV_CMD%
- if exist %SPARK_ENV_CMD% (
- call %SPARK_ENV_CMD%
- )
+ call :LoadSparkEnv
Review comment:
I have confirmed this issue is env set inside `IF` won't take effect
until after whole block executed. Please refer
https://superuser.com/questions/78496/variables-in-batch-file-not-being-set-when-inside-if
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
