dongjoon-hyun commented on a change in pull request #28425:
URL: https://github.com/apache/spark/pull/28425#discussion_r453204166
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -360,6 +360,54 @@ class ExplainSuite extends ExplainSuiteHelper with
DisableAdaptiveExecutionSuite
}
}
}
+
+ test("Explain formatted output for scan operator for datasource V2") {
+ withTempDir { dir =>
+ Seq("parquet", "orc", "csv", "json").foreach { fmt =>
+ val basePath = dir.getCanonicalPath + "/" + fmt
+ val pushFilterMaps = Map (
+ "parquet" ->
+ "|PushedFilers: \\[.*\\(id\\), .*\\(value\\), .*\\(id,1\\),
.*\\(value,2\\)\\]",
+ "orc" ->
+ "|PushedFilers: \\[.*\\(id\\), .*\\(value\\), .*\\(id,1\\),
.*\\(value,2\\)\\]",
+ "csv" ->
+ "|PushedFilers: \\[IsNotNull\\(value\\),
GreaterThan\\(value,2\\)\\]",
+ "json" ->
+ "|remove_marker"
+ )
+ val expected_plan_fragment1 =
+ s"""
+ |\\(1\\) BatchScan
+ |Output \\[2\\]: \\[value#x, id#x\\]
+ |DataFilters: \\[isnotnull\\(value#x\\), \\(value#x > 2\\)\\]
+ |Format: $fmt
+ |Location: InMemoryFileIndex\\[.*\\]
+ |PartitionFilters: \\[isnotnull\\(id#x\\), \\(id#x > 1\\)\\]
+ ${pushFilterMaps.get(fmt).get}
+ |ReadSchema: struct\\<value:int\\>
+ |""".stripMargin.replaceAll("\nremove_marker", "").trim
Review comment:
It seems that we can remove `.replaceAll("\nremove_marker", "")` if we
fix line 376. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
