viirya commented on a change in pull request #28996:
URL: https://github.com/apache/spark/pull/28996#discussion_r453215994
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -2030,7 +2030,22 @@ class Dataset[T] private[sql](
* @group typedrel
* @since 2.3.0
*/
- def unionByName(other: Dataset[T]): Dataset[T] = withSetOperator {
+ def unionByName(other: Dataset[T]): Dataset[T] = unionByName(other, false)
+
+ /**
+ * Returns a new Dataset containing union of rows in this Dataset and
another Dataset.
+ *
+ * The difference between this function and [[union]] is that this function
+ * resolves columns by name (not by position).
+ *
+ * When the parameter `allowMissingColumns` is true, this function allows
different set
+ * of column names between two Datasets. Missing columns at each side, will
be filled with
Review comment:
Good advice.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -2030,7 +2030,22 @@ class Dataset[T] private[sql](
* @group typedrel
* @since 2.3.0
*/
- def unionByName(other: Dataset[T]): Dataset[T] = withSetOperator {
+ def unionByName(other: Dataset[T]): Dataset[T] = unionByName(other, false)
+
+ /**
+ * Returns a new Dataset containing union of rows in this Dataset and
another Dataset.
+ *
+ * The difference between this function and [[union]] is that this function
+ * resolves columns by name (not by position).
+ *
+ * When the parameter `allowMissingColumns` is true, this function allows
different set
+ * of column names between two Datasets. Missing columns at each side, will
be filled with
+ * null values.
+ *
Review comment:
okay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
