dongjoon-hyun commented on a change in pull request #28746:
URL: https://github.com/apache/spark/pull/28746#discussion_r453238831
##########
File path: core/src/main/scala/org/apache/spark/rpc/netty/Dispatcher.scala
##########
@@ -147,7 +147,14 @@ private[netty] class Dispatcher(nettyEnv: NettyRpcEnv,
numUsableCores: Int) exte
/** Posts a one-way message. */
def postOneWayMessage(message: RequestMessage): Unit = {
postMessage(message.receiver.name, OneWayMessage(message.senderAddress,
message.content),
- (e) => throw e)
+ (e) => e match {
+ // SPARK-31922: in local cluster mode, there's always a
RpcEnvStoppedException when
+ // stop is called due to some asynchronous message handling. We catch
the exception
+ // and log it at debug level to avoid verbose error message when user
stop a local
+ // cluster in spark shell.
+ case re: RpcEnvStoppedException => logDebug (s"Message $message
dropped. ${re.getMessage}")
Review comment:
nit. `logDebug (` -> `logDebug(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
