frankyin-factual commented on a change in pull request #28898: URL: https://github.com/apache/spark/pull/28898#discussion_r453293880
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SchemaPruningSuite.scala ########## @@ -460,6 +460,60 @@ abstract class SchemaPruningSuite checkAnswer(query4, Row(2, null) :: Row(2, 4) :: Nil) } + testSchemaPruning("select nested field in window function") { + val windowSql = + """ + |with contact_rank as ( + | select row_number() over (partition by address order by id desc) as rank, + | contacts.* + | from contacts + |) + |select name.first, rank from contact_rank + |where name.first = 'Jane' AND rank = 1 + |""".stripMargin + val query1 = sql(windowSql) + checkScan(query1, "struct<id:int,name:struct<first:string>,address:string>") + checkAnswer(query1, Row("Jane", 1) :: Nil) Review comment: Good catch. `sort by` is a local sort, so I also updated this test to do repartition first to make results more predictable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org