dongjoon-hyun commented on a change in pull request #29061:
URL: https://github.com/apache/spark/pull/29061#discussion_r453333379
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingPointNumbersSuite.scala
##########
@@ -85,8 +85,60 @@ class NormalizeFloatingPointNumbersSuite extends PlanTest {
val optimized = Optimize.execute(query)
val doubleOptimized = Optimize.execute(optimized)
val joinCond = IsNull(a) === IsNull(b) &&
- KnownFloatingPointNormalized(NormalizeNaNAndZero(coalesce(a, 0.0))) ===
- KnownFloatingPointNormalized(NormalizeNaNAndZero(coalesce(b, 0.0)))
+ coalesce(KnownFloatingPointNormalized(NormalizeNaNAndZero(a)),
+ KnownFloatingPointNormalized(NormalizeNaNAndZero(0.0))) ===
+ coalesce(KnownFloatingPointNormalized(NormalizeNaNAndZero(b)),
+ KnownFloatingPointNormalized(NormalizeNaNAndZero(0.0)))
+ val correctAnswer = testRelation1.join(testRelation2, condition =
Some(joinCond))
+
+ comparePlans(doubleOptimized, correctAnswer)
+ }
+
+ test("SPARK-32258: normalize the children of If") {
+ val cond = If(a > 0.1D, a, a + 0.2D) === b
+ val query = testRelation1.join(testRelation2, condition = Some(cond))
+ val optimized = Optimize.execute(query)
+ val doubleOptimized = Optimize.execute(optimized)
+
+ val joinCond = If(a > 0.1D,
+ KnownFloatingPointNormalized(NormalizeNaNAndZero(a)),
+ KnownFloatingPointNormalized(NormalizeNaNAndZero(a + 0.2D))) ===
+ KnownFloatingPointNormalized(NormalizeNaNAndZero(b))
+ val correctAnswer = testRelation1.join(testRelation2, condition =
Some(joinCond))
+
+ comparePlans(doubleOptimized, correctAnswer)
+ }
+
+ test("SPARK-32258: normalize the children of Coalesce") {
+ val cond = If(a > 0.1D, a, a + 0.2D) <=> b
+ val query = testRelation1.join(testRelation2, condition = Some(cond))
+ val optimized = Optimize.execute(query)
+ val doubleOptimized = Optimize.execute(optimized)
+
+ /*
+ val joinCond = If(a > 0.1D,
+ KnownFloatingPointNormalized(NormalizeNaNAndZero(a)),
+ KnownFloatingPointNormalized(NormalizeNaNAndZero(a + 0.2D))) ===
+ KnownFloatingPointNormalized(NormalizeNaNAndZero(b))
+ val correctAnswer = testRelation1.join(testRelation2, condition =
Some(joinCond))
+
+ comparePlans(doubleOptimized, correctAnswer)
+ */
Review comment:
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
