Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4929#discussion_r27183808
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala 
---
    @@ -207,6 +207,26 @@ class SQLQuerySuite extends QueryTest {
         }
       }
     
    +  test("CTE feature") {
    --- End diff --
    
    You might consider putting these tests in HiveQuerySuite, as then the 
answers will be autogenerated.  Also can you add tests for the `FROM src SELECT 
*` case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to