dongjoon-hyun commented on a change in pull request #28957:
URL: https://github.com/apache/spark/pull/28957#discussion_r453462469
##########
File path: dev/lint-python
##########
@@ -168,7 +168,15 @@ function sphinx_test {
# Check that the documentation builds acceptably, skip check if sphinx is
not installed.
if ! hash "$SPHINX_BUILD" 2> /dev/null; then
- echo "The $SPHINX_BUILD command was not found. Skipping pydoc checks
for now."
+ echo "The $SPHINX_BUILD command was not found. Skipping Sphinx build
for now."
+ echo
+ return
+ fi
+
+ # TODO(SPARK-32279): Install Sphinx in Python 3 of Jenkins machines
+ PYTHON_HAS_SPHINX=$(python3 -c 'import importlib.util;
print(importlib.util.find_spec("sphinx") is not None)')
Review comment:
nit. Like this other place, shall we use the variable
`PYTHON_EXECUTABLE` instead of `python3`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
