Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3558#discussion_r27184655
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala ---
    @@ -0,0 +1,53 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst
    +
    +import scala.collection.immutable
    +
    +private[spark] object CatalystConf{
    +  val CASE_SENSITIVE = "spark.sql.caseSensitive"
    +}
    +
    +private[spark] trait CatalystConf {
    --- End diff --
    
    I think the catalyst conf can be as simple as a set of abstract methods 
that need to be implemented by some concrete conf.
    
    ```scala
    trait CatalystConf {
      def caseSensitiveAnalysis: Boolean
    }
    ```
    
    We can have a trivial one for testing: `case class 
SimpleConf(caseSensitiveAnalysis: Boolean) extends CatalystConf` and SQLConf 
can mix this trait in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to