Ngone51 commented on a change in pull request #29032:
URL: https://github.com/apache/spark/pull/29032#discussion_r453605397
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##########
@@ -418,7 +418,8 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
/**
* Mark a given executor as decommissioned and stop making resource offers
for it.
*/
- private def decommissionExecutor(executorId: String): Boolean = {
+ private def decommissionExecutor(executorId: String,
+ decommissionInfo: DecommissionInfo):
Boolean = {
Review comment:
nit: 4 indent.
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##########
@@ -585,10 +586,11 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
/**
* Called by subclasses when notified of a decommissioning executor.
*/
- private[spark] def decommissionExecutor(executorId: String): Unit = {
+ private[spark] def decommissionExecutor(executorId: String,
+ decommissionInfo: DecommissionInfo):
Unit = {
Review comment:
ditto.
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##########
@@ -136,6 +136,8 @@ private[spark] class TaskSchedulerImpl(
// IDs of the tasks running on each executor
private val executorIdToRunningTaskIds = new HashMap[String, HashSet[Long]]
+ private val executorsPendingDecommission = new HashMap[String,
DecommissionInfo]
Review comment:
This is not used at all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
