rdblue commented on a change in pull request #29089:
URL: https://github.com/apache/spark/pull/29089#discussion_r453990069
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala
##########
@@ -1299,8 +1299,9 @@ class ArrowConvertersSuite extends SharedSparkSession {
|}
""".stripMargin
- val a_i = List[Int](1, -1, 2, -2, 2147483647, -2147483648)
- val b_i = List[Option[Int]](Some(1), None, None, Some(-2), None,
Some(-2147483648))
+ // we order values by $"a_i".desc manually as sortBy before coalesce is
ignored
Review comment:
I think we should apply the optimization only if the repartition
requires a shuffle as you suggest. I know that there are users that depend on
this behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
