maropu commented on a change in pull request #29075:
URL: https://github.com/apache/spark/pull/29075#discussion_r454001849
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -207,13 +207,15 @@ trait PredicateHelper extends Logging {
* CNF can explode exponentially in the size of the input expression when
converting [[Or]]
* clauses. Use a configuration [[SQLConf.MAX_CNF_NODE_COUNT]] to prevent
such cases.
*
- * @param condition to be converted into CNF.
+ * @param condition Condition to be converted into CNF.
+ * @param groupExpsFunc A method for grouping intermediate results so that
the final result can be
+ * shorter.
Review comment:
`A method to group expressions for reducing the size of pushed down
predicates and corresponding codegen`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
