agrawaldevesh commented on a change in pull request #29015:
URL: https://github.com/apache/spark/pull/29015#discussion_r454483988
##########
File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
##########
@@ -863,7 +872,29 @@ private[deploy] class Master(
true
}
- private def decommissionWorker(worker: WorkerInfo): Unit = {
+ private def decommissionHostPorts(hostPorts: Seq[String]): Integer = {
+ val hostPortsParsed = hostPorts.map(Utils.parseHostPort)
+ val (hostPortsWithoutPorts, hostPortsWithPorts) =
hostPortsParsed.partition(_._2 == 0)
Review comment:
I would like to please let it remain it as it is since I find two line
statements confusing to read. Its also just 90 columns and within the 100
limit. There is also precedence for one line partition statements elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
