HyukjinKwon commented on a change in pull request #28971:
URL: https://github.com/apache/spark/pull/28971#discussion_r454750891



##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -173,15 +173,6 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable 
with Logging with Seria
     this
   }
 
-  /**
-   * Set multiple parameters together
-   */
-  @deprecated("Use setAll(Iterable) instead", "3.0.0")
-  def setAll(settings: Traversable[(String, String)]): SparkConf = {

Review comment:
       @srowen, BTW, it might be best to file a JIRA as a reminder to keep this 
API back if we can't make Scala 2.13 in Spark 3.1.
   
   I believe it is legitimate and inevitable to remove this because of Scala 
2.13 but it might be problematic if we can't make it in Spark 3.1, and have a 
release out only with Scala 2.12.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to