HyukjinKwon commented on a change in pull request #27366:
URL: https://github.com/apache/spark/pull/27366#discussion_r454927758
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
##########
@@ -85,8 +87,9 @@ class JacksonParser(
private def makeStructRootConverter(st: StructType): JsonParser =>
Iterable[InternalRow] = {
val elementConverter = makeConverter(st)
val fieldConverters = st.map(_.dataType).map(makeConverter).toArray
+ val jsonFilters = new JsonFilters(filters, st)
Review comment:
No big deal but wouldn't it better to just use `NoopFilters` when the
switch is off? For example,
```scala
val jsonFilters = if (SQLConf.get.jsonFilterPushDown) {
new JsonFilters(filters, st)
} else {
new NoopFilters()
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
