prakharjain09 commented on a change in pull request #28708:
URL: https://github.com/apache/spark/pull/28708#discussion_r455008439
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -1285,6 +1314,9 @@ private[spark] class BlockManager(
require(blockId != null, "BlockId is null")
require(level != null && level.isValid, "StorageLevel is null or invalid")
+ if (isDecommissioning()) {
+ throw new BlockSavedOnDecommissionedBlockManagerException(blockId)
Review comment:
why are we throwing exception here? doPut on a decommissioning executor
might haven been called by the running task - so can this line lead to task
failure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
