cloud-fan commented on a change in pull request #29064:
URL: https://github.com/apache/spark/pull/29064#discussion_r455194517
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
##########
@@ -90,6 +92,41 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder(conf) {
ResetCommand
}
+ /**
+ * Create a [[SetCommand]] logical plan to set
[[SQLConf.SESSION_LOCAL_TIMEZONE]]
+ * Example SQL :
+ * {{{
+ * SET TIME ZONE LOCAL;
+ * SET TIME ZONE 'Asia/Shanghai';
+ * SET TIME ZONE INTERVAL 10 HOURS;
+ * }}}
+ */
+ override def visitSetTimeZone(ctx: SetTimeZoneContext): LogicalPlan =
withOrigin(ctx) {
+ val key = SQLConf.SESSION_LOCAL_TIMEZONE.key
+ if (ctx.interval != null) {
+ val interval = parseIntervalLiteral(ctx.interval)
+ if (interval.months != 0 || interval.days != 0 ||
+ math.abs(interval.microseconds) > 18 *
DateTimeConstants.MICROS_PER_HOUR ||
+ interval.microseconds % DateTimeConstants.MICROS_PER_SECOND != 0) {
+ throw new ParseException("The interval value must be in the range of
[-18, +18] hours" +
+ " with second precision",
+ ctx.interval())
+ } else {
+ val seconds = (interval.microseconds /
DateTimeConstants.MICROS_PER_SECOND).toInt
+ SetCommand(Some(key ->
Some(ZoneOffset.ofTotalSeconds(seconds).toString)))
+ }
+ } else if (ctx.timezone != null) {
+ ctx.timezone.getType match {
+ case SqlBaseParser.LOCAL =>
+ SetCommand(Some(key -> Some(TimeZone.getDefault.getID)))
Review comment:
So we don't respect the environment variable `TZ`. Shall we update the
doc?
##########
File path: docs/sql-ref-syntax-aux-conf-mgmt-set-timezone.md
##########
@@ -0,0 +1,67 @@
+---
+layout: global
+title: SET TIME ZONE
+displayTitle: SET TIME ZONE
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+---
+
+### Description
+
+The `SET TIME ZONE` command sets the current default time
zone(`spark.sql.session.timeZone`) displacement for the `SparkSession`.
+
+### Syntax
+
+```sql
+SET TIME ZONE LOCAL
+SET TIME ZONE 'timezone_value'
+SET TIME ZONE INTERVAL interval_literal
+```
+
+### Parameters
+
+* **LOCAL**
+
+ Respectively set the time zone the one specified in environment variable
`TZ`, or to the operating system time zone if `TZ` is undefined.
+
+* **timezone_value**
+
+ The ID of session local timezone in the format of either region-based zone
IDs or zone offsets. Region IDs must have the form 'area/city', such as
'America/Los_Angeles'. Zone offsets must be in the format '`(+|-)HH`',
'`(+|-)HH:mm`' or '`(+|-)HH:mm:ss`', e.g '-08', '+01:00' or '-13:33:33'. Also,
'UTC' and 'Z' are supported as aliases of '+00:00'. Other short names are not
recommended to use because they can be ambiguous.
+
+* **interval_literal**
+
+ The [interval literal](sql-ref-literals.html#interval-literal) represents
the displacement of time zone to the 'UTC'. It must be in the range of [-18,
18] hours and max to second precision, e.g. `INTERVAL 2 HOURS 30 MINITUES` or
`INTERVAL '15:40:32' HOUR TO SECOND`.
+
+### Examples
+
+```sql
+-- Set time zone to the system default.
+SET TIME ZONE LOCAL;
+
+-- Set time zone to the region-based zone ID.
+SET TIME ZONE 'America/Los_Angeles'
+
+-- Set time zone to the Zone offset.
+SET TIME ZONE '+08:00';
+
+-- Set time zone with intervals.
+SET TIME ZONE INTERVAL 1 HOUR 30 MINUTES;
+SET TIME ZONE INTERVAL '08:30:00' HOUR TO SECOND;
+```
+
Review comment:
can we give some error examples?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
