MaxGekk commented on a change in pull request #27366:
URL: https://github.com/apache/spark/pull/27366#discussion_r455227747
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/csv/UnivocityParserSuite.scala
##########
@@ -303,20 +303,6 @@ class UnivocityParserSuite extends SparkFunSuite with
SQLHelper {
requiredSchema = StructType.fromDDL("i INTEGER, d DOUBLE"),
filters = Seq(EqualTo("d", 3.14)),
expected = Some(InternalRow(1, 3.14)))
-
- val errMsg = intercept[IllegalArgumentException] {
- check(filters = Seq(EqualTo("invalid attr", 1)), expected = None)
- }.getMessage
- assert(errMsg.contains("invalid attr does not exist"))
Review comment:
I don't remember already why I removed the tests half year ago. Let me
try to add them back. I would guess because they are useless since filters w/
invalid attrs must not pushed down at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
