cloud-fan commented on a change in pull request #29032:
URL: https://github.com/apache/spark/pull/29032#discussion_r455237329
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -715,7 +715,8 @@ class DAGSchedulerSuite extends SparkFunSuite with
LocalSparkContext with TimeLi
accumUpdates: Array[(Long, Seq[AccumulatorV2[_, _]])],
blockManagerId: BlockManagerId,
executorUpdates: Map[(Int, Int), ExecutorMetrics]): Boolean = true
- override def executorDecommission(executorId: String): Unit = {}
+ override def executorDecommission(executorId: String,
Review comment:
ditto: indentation
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/ExternalClusterManagerSuite.scala
##########
@@ -90,7 +90,8 @@ private class DummyTaskScheduler extends TaskScheduler {
override def notifyPartitionCompletion(stageId: Int, partitionId: Int): Unit
= {}
override def setDAGScheduler(dagScheduler: DAGScheduler): Unit = {}
override def defaultParallelism(): Int = 2
- override def executorDecommission(executorId: String): Unit = {}
+ override def executorDecommission(executorId: String,
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
