venkata91 commented on pull request #28287: URL: https://github.com/apache/spark/pull/28287#issuecomment-658957953
> yes we have a test in TaskSchedulerImplSuite that checks to make sure it aborted, but I don't think it covers when dynamic allocation on, so it doesn't hit your new code. So we would want to add a test where it can't acquire a new executor and aborts. I think the new test which I added is just duplicated. Do you think its better to just add the config to enable dynamic allocation to the other test itself in order to avoid the duplication ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
