Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5199#discussion_r27209161
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/CompactBuffer.scala ---
@@ -152,6 +152,20 @@ private[spark] class CompactBuffer[T: ClassTag]
extends Seq[T] with Serializable
}
private[spark] object CompactBuffer {
+ def constantEmpty[T: ClassTag](): CompactBuffer[T] = new
CompactBuffer[T] {
+ override def apply(position: Int): T =
+ sys.error("apply() is not valid for a constant empty buffer")
--- End diff --
Can this throw `UnsupportedOperationException` instead? this makes a bald
`RuntimeException` which is slightly poor form to throw.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
