karuppayya commented on a change in pull request #28804:
URL: https://github.com/apache/spark/pull/28804#discussion_r455402409
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2196,6 +2196,25 @@ object SQLConf {
.checkValue(bit => bit >= 10 && bit <= 30, "The bit value must be in
[10, 30].")
.createWithDefault(16)
+ val SKIP_PARTIAL_AGGREGATE_ENABLED =
+ buildConf("spark.sql.aggregate.partialaggregate.skip.enabled")
+ .internal()
+ .doc("Avoid sort/spill to disk during partial aggregation")
+ .booleanConf
+ .createWithDefault(true)
+
+ val SKIP_PARTIAL_AGGREGATE_THRESHOLD =
+ buildConf("spark.sql.aggregate.partialaggregate.skip.threshold")
+ .internal()
+ .longConf
+ .createWithDefault(100000)
Review comment:
@cloud-fan we skip partial aggregartion only when the aggragation was
not able to cut down records by 50%(define by
spark.sql.aggregate.partialaggregate.skip.ratio). In this case it will not kick
in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
