HyukjinKwon commented on a change in pull request #28874:
URL: https://github.com/apache/spark/pull/28874#discussion_r455457528
##########
File path: python/pyspark/cloudpickle.py
##########
@@ -87,8 +87,8 @@
PY2 = True
PY2_WRAPPER_DESCRIPTOR_TYPE = type(object.__init__)
PY2_METHOD_WRAPPER_TYPE = type(object.__eq__)
- PY2_CLASS_DICT_BLACKLIST = (PY2_METHOD_WRAPPER_TYPE,
- PY2_WRAPPER_DESCRIPTOR_TYPE)
+ PY2_CLASS_DICT_SKIP_PICKLE_METHOD_TYPE = (PY2_METHOD_WRAPPER_TYPE,
+ PY2_WRAPPER_DESCRIPTOR_TYPE)
Review comment:
Hey let's dont change this file but keep as the release (and fix their
release and port it together). It's the exact copy of cloudpickle release. We
just port their fixes and dont have conflicts here for management purpose.
Linters skip this file too and we had to put a lot of efforts to resolve the
conflicts here before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
