leanken commented on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-659144171
> For example. > -- Case 4 > -- (one column null, other column matches a row in the subquery result -> row not returned) > SELECT * > FROM m > WHERE b = 1.0 -- Matches (null, 1.0) > AND (a, b) NOT IN (SELECT * > FROM s > WHERE c IS NOT NULL) -- Matches (0, 1.0), (2, 3.0), (4, null) > ; > > in this case, i can't not use InternalRow(null, 1.0) to lookup in HashedRelation. I need to exclude all null column, and try found match within the not null column, which i think HashedRelation is not a suitable structure for multi-column support. But if change into multi column and need to deal with null column, which means i can't use Hash to lookup, so it will still be a M*N, that's no gona help. ping @maropu on the multi column support conclusion. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
