cloud-fan commented on a change in pull request #29015:
URL: https://github.com/apache/spark/pull/29015#discussion_r455688453
##########
File path: core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala
##########
@@ -108,6 +108,9 @@ private[deploy] object DeployMessages {
case class Heartbeat(workerId: String, worker: RpcEndpointRef) extends
DeployMessage
+ // Out of band commands to Master
+ case class DecommissionHosts(hostnames: Seq[String])
Review comment:
If we want to be accurate, this should be `DecommissionWorkersByHost`.
Looking at other classes in this file, they are all about master/worker,
e.g. `RegisterWorker`, `WorkerDecommission`, etc. That's why I suggest
`DecommissionWorkers`, and add comments to explain the workers are specified by
hosts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
