cloud-fan commented on a change in pull request #29079:
URL: https://github.com/apache/spark/pull/29079#discussion_r455724248
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInJoinSuite.scala
##########
@@ -103,46 +119,69 @@ class CoalesceBucketsInSortMergeJoinSuite extends
SQLTestUtils with SharedSparkS
}
test("bucket coalescing - basic") {
- withSQLConf(SQLConf.COALESCE_BUCKETS_IN_SORT_MERGE_JOIN_ENABLED.key ->
"true") {
+ withSQLConf(SQLConf.COALESCE_BUCKETS_IN_JOIN_ENABLED.key -> "true") {
+ run(JoinSetting(
+ RelationSetting(4, None), RelationSetting(8, Some(4)), joinOperator =
sortMergeJoin))
+ run(JoinSetting(
+ RelationSetting(4, None), RelationSetting(8, Some(4)), joinOperator =
shuffledHashJoin,
+ shjBuildSide = Some(BuildLeft)))
+ // Coalescing bucket should not happen when the target is on shuffled
hash join
+ // build side.
run(JoinSetting(
- RelationSetting(4, None), RelationSetting(8, Some(4)), isSortMergeJoin
= true))
+ RelationSetting(4, None), RelationSetting(8, None), joinOperator =
shuffledHashJoin,
+ shjBuildSide = Some(BuildRight)))
}
- withSQLConf(SQLConf.COALESCE_BUCKETS_IN_SORT_MERGE_JOIN_ENABLED.key ->
"false") {
- run(JoinSetting(RelationSetting(4, None), RelationSetting(8, None),
isSortMergeJoin = true))
+ withSQLConf(SQLConf.COALESCE_BUCKETS_IN_JOIN_ENABLED.key -> "false") {
+ run(JoinSetting(
+ RelationSetting(4, None), RelationSetting(8, None), joinOperator =
broadcastHashJoin))
Review comment:
nit: test SMJ as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
