srowen commented on pull request #29121: URL: https://github.com/apache/spark/pull/29121#issuecomment-659402844
It's not a bad idea if there are material benefits to not importing modules. (Unlike in the JVM where generally this only has any impact during compilation). What about just removing the ones that can be removed, and not attempting to enforce / suppress F401? that's a smaller one-time cleanup. How reliable is detection of unused imports, as importing can have side-effects? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
