cloud-fan commented on a change in pull request #29101:
URL: https://github.com/apache/spark/pull/29101#discussion_r455909513
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -201,126 +201,51 @@ trait PredicateHelper extends Logging {
case e => e.children.forall(canEvaluateWithinJoin)
}
- /**
- * Convert an expression into conjunctive normal form.
- * Definition and algorithm:
https://en.wikipedia.org/wiki/Conjunctive_normal_form
- * CNF can explode exponentially in the size of the input expression when
converting [[Or]]
- * clauses. Use a configuration [[SQLConf.MAX_CNF_NODE_COUNT]] to prevent
such cases.
- *
- * @param condition to be converted into CNF.
- * @return the CNF result as sequence of disjunctive expressions. If the
number of expressions
- * exceeds threshold on converting `Or`, `Seq.empty` is returned.
+ /*
+ * Returns a filter that it's output is a subset of `outputSet` and it
contains all possible
+ * constraints from `condition`. This is used for predicate pushdown.
+ * When there is no such convertible filter, `None` is returned.
Review comment:
`such convertible filter` -> `such filter`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
