huaxingao commented on a change in pull request #29112:
URL: https://github.com/apache/spark/pull/29112#discussion_r455923815
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/classification/FMClassifier.scala
##########
@@ -85,7 +85,6 @@ class FMClassifier @Since("3.0.0") (
*/
@Since("3.0.0")
def setFactorSize(value: Int): this.type = set(factorSize, value)
- setDefault(factorSize -> 8)
Review comment:
I move setDefault for these params to FactorizationMachinesParams in
FMRegressor when I fixed solver last time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
