zero323 commented on a change in pull request #29122:
URL: https://github.com/apache/spark/pull/29122#discussion_r456040994
##########
File path: python/pyspark/ml/tuning.py
##########
@@ -500,13 +501,13 @@ class CrossValidatorModel(Model, _CrossValidatorParams,
MLReadable, MLWritable):
.. versionadded:: 1.4.0
"""
- def __init__(self, bestModel, avgMetrics=[], subModels=None):
+ def __init__(self, bestModel, avgMetrics: List = None, subModels=None):
Review comment:
Out of curiosity ‒why do we need default here?
##########
File path: python/pyspark/ml/tuning.py
##########
@@ -500,13 +501,13 @@ class CrossValidatorModel(Model, _CrossValidatorParams,
MLReadable, MLWritable):
.. versionadded:: 1.4.0
"""
- def __init__(self, bestModel, avgMetrics=[], subModels=None):
+ def __init__(self, bestModel, avgMetrics: List = None, subModels=None):
Review comment:
Out of curiosity ‒ why do we need default here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
