HeartSaVioR commented on pull request #29131: URL: https://github.com/apache/spark/pull/29131#issuecomment-659747096
This looks reasonable to me as well - as there has been two safety guards and even with this patch there's still one safety guard. In worst case (if Kafka client encounters KAFKA-7703-like issue in all trials) it can still make a difference, but even we don't have a strong faith of Kafka client we don't tend to believe Kafka client provides wrong value consistently. With reasonable count of retrial it shouldn't matter. I'd still like to see @zsxwing voice on this, as he looks to be the one struggled with Kafka client bugs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
