maropu commented on a change in pull request #28852:
URL: https://github.com/apache/spark/pull/28852#discussion_r456152769
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -135,7 +136,16 @@ class SessionCatalog(
private val tableRelationCache: Cache[QualifiedTableName, LogicalPlan] = {
Review comment:
Ah, I see. As you suggested, the most painful part (listed files) has
already been cached there. But, it seems some datasources still has somewhat
processing costs when resolving a relation (e.g., JDBC datasources send a query
to an external database for schema resolution), so I think we need to carefully
check performance impacts for removing this cache.
https://github.com/apache/spark/blob/fb519251237892ad474592d19bf4f193e2a9e2b6/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala#L256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
