rednaxelafx commented on pull request #29124: URL: https://github.com/apache/spark/pull/29124#issuecomment-659796533
Just a note: both `-Yrepl-class-based` and `-Yrepl-use-magic-imports` are very nice improvements to the Scala REPL, and I'd love to see them in Spark. But they can also potentially significantly impact how Spark's Scala REPL interact, so I wonder whether or not we need some more tests cases to show that the REPL behavior is consistent / has not regressed with regards to them. The test coverage in Spark's RPEL is quite weak... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
