cloud-fan commented on a change in pull request #29135:
URL: https://github.com/apache/spark/pull/29135#discussion_r456311045
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##########
@@ -226,7 +226,10 @@ object RewriteDistinctAggregates extends Rule[LogicalPlan]
{
val naf = patchAggregateFunctionChildren(af) { x =>
distinctAggChildAttrLookup.get(x).map(evalWithinGroup(id, _))
}
- (e, e.copy(aggregateFunction = naf, isDistinct = false))
+ val filterOpt = e.filter.map(_.transform {
+ case a: Attribute => distinctAggChildAttrLookup.getOrElse(a, a)
Review comment:
what does it do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
